Hello back! So, to make things more replicable, yesterday we worked on the Makefile. Today we’ll continue this work!
In retrospect, I realized it’s not the best practice to set the Python virtual environment in the Makefile, as not every user may want to do that (or maybe not specifically that way.) Let’s start fixing that:
ifndef IG_USER $(error IG_USER is not set) endif PYTHON=../venv/bin/python # <-- we'll change this SRC=../src all: shortcodes shortcodes: $(PYTHON) $(SRC)/get-shortcodes.py clean: rm -rf \#100daysofpractice/
ifndef IG_USER $(error IG_USER is not set) endif PYTHON=python SRC=../src all: shortcodes shortcodes: $(PYTHON) $(SRC)/get-shortcodes.py clean: rm -rf \#100daysofpractice/
It would also be nice to
[X]use variables for filenames
[X]change the name of the target to reflect the output filename
[X]add target for test file; get it directly from the original
[X]add target for sort file
[X]add target for uniq file
cleantarget to reflect the changes
Something very important is to update the instructions on how to obtain the several shortcode files.
[X]Use Org format for the main README
[X]have the instructions in the main README
[X]add description of the shortcodes
[X]add quick installation instructions
[X]add a usage example
[X]do not set environment variables for Instagram user and password
All I can say is that it was really humbling to test all the changes below in a clean new clone… But now I’m pretty sure that anyone can replicate the process, which is great for Science! Cheesy, but true LOL!